WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 220449
JavaScriptCore API headers contain project style includes
https://bugs.webkit.org/show_bug.cgi?id=220449
Summary
JavaScriptCore API headers contain project style includes
Alexey Proskuryakov
Reported
2021-01-07 17:39:48 PST
Maybe I'm missing some reason for it, but it seems wrong for framework headers to use project style includes.
rdar://problem/71493605
Attachments
proposed patch
(1.71 KB, patch)
2021-01-07 17:45 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2021-01-07 17:45:56 PST
Created
attachment 417234
[details]
proposed patch
Alexey Proskuryakov
Comment 2
2021-01-07 17:47:35 PST
There are also lots of SPI headers, where the include style is wrong too, but that's a cleanup for another day.
Yusuke Suzuki
Comment 3
2021-01-08 10:39:05 PST
Comment on
attachment 417234
[details]
proposed patch r=me
EWS
Comment 4
2021-01-08 12:23:12 PST
Committed
r271317
: <
https://trac.webkit.org/changeset/271317
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 417234
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug