Bug 220381

Summary: Use sendWithAsyncReply instead of dataCallback for icon loading
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, ews-watchlist, gustavo, japhet, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Description Alex Christensen 2021-01-06 13:19:44 PST 
Use sendWithAsyncReply instead of dataCallback for icon loading
Comment 1 Alex Christensen 2021-01-06 13:27:59 PST 
Created attachment 417122 [details]
Patch
Comment 2 Alex Christensen 2021-01-06 13:34:03 PST 
Created attachment 417124 [details]
Patch
Comment 3 Alex Christensen 2021-01-06 14:01:53 PST 
Created attachment 417127 [details]
Patch
Comment 4 Alex Christensen 2021-01-06 14:06:16 PST 
Created attachment 417128 [details]
Patch
Comment 5 EWS Watchlist 2021-01-06 14:06:57 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 6 Alex Christensen 2021-01-06 16:40:11 PST 
Created attachment 417139 [details]
Patch
Comment 7 youenn fablet 2021-01-11 04:56:07 PST 
Comment on attachment 417139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417139&action=review

> Source/WebCore/loader/DocumentLoader.cpp:327
> +        callback(nullptr);

Can callback modify m_iconLoaders?
Given we do m_iconLoaders.clear() below, can we do a std::exchange?

> Source/WebCore/loader/DocumentLoader.cpp:2193
> +    m_iconLoaders.set(WTFMove(iconLoader), WTFMove(completionHandler));

s/set/add/
Comment 8 Alex Christensen 2021-01-11 13:00:35 PST 
Created attachment 417405 [details]
Patch
Comment 9 EWS 2021-01-11 13:36:46 PST 
Committed r271378: <https://trac.webkit.org/changeset/271378>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417405 [details].
Comment 10 Radar WebKit Bug Importer 2021-01-11 13:37:17 PST 
<rdar://problem/73011806>
Comment 11 Alex Christensen 2021-01-11 15:30:43 PST 
http://trac.webkit.org/r271383