Bug 220319

Summary: WebKit IPC message names should indicate if the message is synchronous
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebKit2Assignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220318    
Bug Blocks: 217211, 220410    
Attachments:
Description Flags
Patch
none
Patch none

Kimmo Kinnunen
Reported 2021-01-05 04:01:36 PST
WebKit IPC message names should indicate if the message is synchronous Currently IPC message can be either synchronous or asynchronous but not both. There should be an efficient way to check this based on the message name. Checking this is important, because the dispatch functions for sync vs async messages on the receive side have different signatures. This is needed because in WebGL GPUP "IPC stream" mode, the messages do not encode the message status byte for simplicity of operation.
Attachments
Patch (30.37 KB, patch)
2021-01-05 04:11 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (32.56 KB, patch)
2021-01-07 07:56 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-01-05 04:11:48 PST
Created attachment 416988 [details] Patch
Kimmo Kinnunen
Comment 2 2021-01-07 07:56:47 PST
Created attachment 417178 [details] Patch
EWS
Comment 3 2021-01-07 10:48:02 PST
Committed r271243: <https://trac.webkit.org/changeset/271243> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417178 [details].
Radar WebKit Bug Importer
Comment 4 2021-01-07 10:49:17 PST
<rdar://problem/72895617>
Note You need to log in before you can comment on or make changes to this bug.