Bug 220319 - WebKit IPC message names should indicate if the message is synchronous
Summary: WebKit IPC message names should indicate if the message is synchronous
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 220318
Blocks: webglgpup 220410
  Show dependency tree / graph
 
Reported: 2021-01-05 04:01 PST by Kimmo Kinnunen
Modified: 2021-01-07 10:49 PST (History)
2 users (show)

See Also:

Attachments
Patch (30.37 KB, patch)
2021-01-05 04:11 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (32.56 KB, patch)
2021-01-07 07:56 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-01-05 04:01:36 PST 
WebKit IPC message names should indicate if the message is synchronous

Currently IPC message can be either synchronous or asynchronous but not both.
There should be an efficient way to check this based on the message name.
Checking this is important, because the dispatch functions for sync vs async messages on the receive side have different signatures.

This is needed because in WebGL GPUP "IPC stream" mode, the messages do not encode the message status byte for simplicity of operation.
Comment 1 Kimmo Kinnunen 2021-01-05 04:11:48 PST 
Created attachment 416988 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-01-07 07:56:47 PST 
Created attachment 417178 [details]
Patch
Comment 3 EWS 2021-01-07 10:48:02 PST 
Committed r271243: <https://trac.webkit.org/changeset/271243>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417178 [details].
Comment 4 Radar WebKit Bug Importer 2021-01-07 10:49:17 PST 
<rdar://problem/72895617>