| Summary: | Make EventNames usable from multiple threads | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
| Component: | WebCore Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Proskuryakov
2008-11-01 08:03:44 PDT
Created attachment 24836 [details]
proposed patch
Created attachment 24837 [details]
proposed patch
Oops, sent before saving...
Comment on attachment 24837 [details] proposed patch Any uses in WebKit outside of the "mac" and "win" directories? Typo "Atimic" in one place. What performance impact does this change have? Why is the EventNames constructor public? Why is "int dummy" a member of EventNames? Just to allow the initialization macro to work? I think both the constructor and the dummy member should be private. > : dummy (0) There should be a space after the word "dummy" here? > // Initialization is not thread safe, so this function must be called from the main thread first. Why not assert this? r=me (In reply to comment #3) > (From update of attachment 24837 [details] [edit]) > Any uses in WebKit outside of the "mac" and "win" directories? No, grepping didn't find anything else. > What performance impact does this change have? No change on PLT for me. Should I test anything else? I worried about a PLT regression, because this changed AtomicString construction and destruction, but event dispatching is probably not that hot - or is it? > Why is "int dummy" a member of EventNames? Just to allow the initialization macro > to work? Yes, that's the reason. Committed revision 38094. |