Bug 220259

Summary:

[LFC][IFC] Do not use LineBox::isConsideredEmpty when checking if inline box stretches the line box

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

zalan

Reported 2021-01-04 19:28:12 PST

e.g. <!DOCTYPE html><span><div></div></span> the pre and post blocks block container (pre) inline box block container block container (post) inline box -no struts in these generated content.

Attachments
Patch (13.53 KB, patch) 2021-01-04 19:34 PST, zalan	no flags	Details Formatted Diff Diff
Patch (13.54 KB, patch) 2021-01-10 20:16 PST, zalan	no flags	Details Formatted Diff Diff
Patch (13.54 KB, patch) 2021-01-13 09:53 PST, zalan	no flags	Details Formatted Diff Diff
Patch (8.65 KB, patch) 2021-01-14 06:58 PST, zalan	no flags	Details Formatted Diff Diff
Patch (10.17 KB, patch) 2021-01-15 20:37 PST, zalan	no flags	Details Formatted Diff Diff
Patch (10.15 KB, patch) 2021-01-15 20:43 PST, zalan	no flags	Details Formatted Diff Diff
Patch (10.50 KB, patch) 2021-01-15 21:40 PST, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2021-01-04 19:34:37 PST

Created attachment 416970 [details] Patch

zalan

Comment 2 2021-01-10 20:16:26 PST

Created attachment 417360 [details] Patch

Antti Koivisto

Comment 3 2021-01-10 22:28:07 PST

Comment on attachment 417360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417360&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.h:-60 > - bool isLineConsideredEmpty { true }; Nice

Radar WebKit Bug Importer

Comment 4 2021-01-11 19:29:13 PST

<rdar://problem/73023402>

zalan

Comment 5 2021-01-13 09:53:59 PST

Created attachment 417542 [details] Patch

zalan

Comment 6 2021-01-14 06:58:17 PST

Created attachment 417617 [details] Patch

zalan

Comment 7 2021-01-15 20:37:39 PST

Created attachment 417757 [details] Patch