Bug 220235

Summary: [WASM-References] Fix data section parsing and add more tests from ref-types
Product: WebKit Reporter: Dmitry <dbezhetskov>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Dmitry
Reported 2021-01-04 02:48:18 PST
[WASM-References] Fix data section parsing and add more tests from ref-types
Attachments
Patch (400.79 KB, patch)
2021-01-04 02:55 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (400.68 KB, patch)
2021-01-04 20:11 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry
Comment 1 2021-01-04 02:55:13 PST
Created attachment 416931 [details] Patch
Yusuke Suzuki
Comment 2 2021-01-04 10:04:40 PST
Comment on attachment 416931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416931&action=review r=me with comment. > Source/JavaScriptCore/wasm/WasmSectionParser.cpp:747 > + const char* errorMessage = Options::useWebAssemblyReferences() ? "th Data segment's flag" : "th Data segment's index"; I think we should just throw an error with `"th Data segment's flag"`.
Dmitry
Comment 3 2021-01-04 20:11:20 PST
Created attachment 416971 [details] Patch
EWS
Comment 4 2021-01-04 21:02:02 PST
Committed r271141: <https://trac.webkit.org/changeset/271141> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416971 [details].
Radar WebKit Bug Importer
Comment 5 2021-01-04 21:03:16 PST
<rdar://problem/72802112>
Note You need to log in before you can comment on or make changes to this bug.