Bug 220210

Summary:

[LFC Display] Give display boxes a parent pointer

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+

Description Simon Fraser (smfr) 2020-12-31 08:57:09 PST

[LFC Display] Give display boxes a parent pointer

Comment 1 Simon Fraser (smfr) 2020-12-31 08:57:54 PST

Created attachment 416866 [details]
Patch

Comment 2 zalan 2021-01-02 20:09:38 PST

Comment on attachment 416866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416866&action=review

> Source/WebCore/display/css/DisplayBox.h:73
> +    ContainerBox* parent() const { return m_parent; }

I usually do a const and a non-const version of getters like this (unless you really only need a const ContainerBox* parent())

Comment 3 Simon Fraser (smfr) 2021-01-04 10:15:21 PST

https://trac.webkit.org/r271134

Comment 4 Radar WebKit Bug Importer 2021-01-04 10:16:36 PST

<rdar://problem/72794178>