Bug 22020
| Summary: | Basic windows types (RECT, POINT, etc) should be guarded by WIN_OS instead of WIN | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, aroben |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | OS X 10.5 | ||
Eric Seidel (no email)
Basic windows types (RECT, POINT, etc) should be guarded by WIN_OS instead of WIN
We don't actually use them in Chromium (I don't think), but we probably should (instead of our own custom conversion functions).
I guess that means we'd have a platform/graphics/win_os then to hold IntRectWinOS, etc? Or maybe it can just stay in win/ (which I think I'd prefer).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dave Hyatt
I think it should just stay in win/. If Chromium has to dip into that dir for a couple of files that's fine.
Ahmad Saleem
ap@webkit.org - Is it something we need today? Thanks!
Alexey Proskuryakov
No, it's just a refactoring that was under consideration in 2008 (and rejected even then).