Summary: | [GTK][CMake] Add a build switch USE_OPENGL_OR_ES to be able to disable OpenGL and ES | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | monson <holymonson> | ||||||||||
Component: | WebKitGTK | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | annulen, bugs-noreply, dino, ews-watchlist, gyuyoung.kim, Hironori.Fujii, julianaito, kbr, ryuan.choi, sergio | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=219916 | ||||||||||||
Attachments: |
|
Description
monson
2020-12-28 07:22:36 PST
Created attachment 416851 [details]
Patch
Created attachment 416852 [details]
Patch
What do you think about this patch? Could you test the patch on your platform? Created attachment 416862 [details]
it's also needed to disable USE_GSTREAMER_GL
Hi,
Thanks for taking care of this!
I've tried your patch against the latest WebKit sources on OpenBSD/amd64,
the build failed because it still defines USE_GSTREAMER_GL, so there are
missing symbols.
I'm attaching your patch with an addition; i made USE_GSTREAMER_GL depends
on USE_OPENGL_OR_ES.
Then it builds properly on this platform; runtime is fine as long i don't play
videos, in such a case the web process crash with:
"WebKit wasn't able to find a WebVTT encoder. Not continuing without platform support for subtitles."
When using our package, and as such with GL enabled, the webprocess does
not crash, while displaying the same message about WebVTT. This is not a deal
breaker as far as i'm concerned, i can disable USE_VIDEO -- but i'm pretty sure
you won't have the same point of view.
I can't try on OpenBSD/macppc for the moment (that's where that new option
really matters for the OpenBSD port), but it should cause no issue.
Comment on attachment 416862 [details] it's also needed to disable USE_GSTREAMER_GL View in context: https://bugs.webkit.org/attachment.cgi?id=416862&action=review Thank you very much for the testing. > Source/cmake/GStreamerDependencies.cmake:1 > +WEBKIT_OPTION_DEPEND(USE_GSTREAMER_GL USE_OPENGL_OR_ES) Hmm, this file is also used by WPE port which always uses OpenGL and doesn't have USE_OPENGL_OR_ES build switch. Created attachment 416871 [details]
Patch
Hi Charlene and Monson, could you debug the video issue in another bug ticket? It seems that GTK port maintainers aren't interested in no OpenGL build configuration. If nobody is willing to maintaining the no OpenGL build configuration, WebKitGTK should remove those compilation switches. Comment on attachment 416871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416871&action=review > Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:35 > +#include <X11/Xutil.h> Looks good to me but I don't speak for this X11 line, because I'm mainly building GTK port on macos, not familiar with X11 target nor WPE port. Comment on attachment 416871 [details]
Patch
In case you still need a review, upon glance this looks fine to me - but if there are other stakeholders who aren't reviewers, please wait for their go-ahead. r+
Comment on attachment 416871 [details] Patch Clearing flags on attachment: 416871 Committed r271220: <https://trac.webkit.org/changeset/271220> All reviewed patches have been landed. Closing bug. |