Bug 220179

Summary: Share meta refresh logic
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, japhet, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2020-12-27 08:13:02 PST
Share meta refresh logic between Document and FrameLoader.
Attachments
Patch (4.97 KB, patch)
2020-12-27 08:15 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (5.14 KB, patch)
2021-01-03 03:21 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2020-12-27 08:15:12 PST
Created attachment 416822 [details] Patch
Darin Adler
Comment 2 2021-01-02 16:03:58 PST
Comment on attachment 416822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416822&action=review > Source/WebCore/ChangeLog:8 > + Share meta refresh logic between Document and FrameLoader. This change is great; two copies seems silly! Bigger picture, long ago we tried to break apart Document and Frame so they wouldn’t be super-huge "god objects", something we got part way through and never finished. I worry that code moving from FrameLoader to Frame and Document starts to undo that.
Rob Buis
Comment 3 2021-01-03 03:21:22 PST
Created attachment 416909 [details] Patch
EWS
Comment 4 2021-01-03 05:48:15 PST
Committed r271125: <https://trac.webkit.org/changeset/271125> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416909 [details].
Radar WebKit Bug Importer
Comment 5 2021-01-03 05:49:16 PST
<rdar://problem/72776134>
Rob Buis
Comment 6 2021-01-03 06:42:10 PST
Comment on attachment 416822 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416822&action=review >> Source/WebCore/ChangeLog:8 >> + Share meta refresh logic between Document and FrameLoader. > > This change is great; two copies seems silly! > > Bigger picture, long ago we tried to break apart Document and Frame so they wouldn’t be super-huge "god objects", something we got part way through and never finished. I worry that code moving from FrameLoader to Frame and Document starts to undo that. Thanks for that reminder! Based on that, I moved the new method to FrameLoader instead of Document.
Note You need to log in before you can comment on or make changes to this bug.