Bug 220158

Summary: Assorted fixes for bisect-builds
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch none

Alexey Proskuryakov
Reported 2020-12-26 13:14:42 PST
bisect-builds doesn't work with Python 3, and is buggy in several ways.
Attachments
proposed patch (22.78 KB, patch)
2020-12-26 13:15 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (22.77 KB, patch)
2021-01-06 09:21 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2020-12-26 13:15:46 PST
Created attachment 416790 [details] proposed patch
Radar WebKit Bug Importer
Comment 2 2021-01-02 13:15:15 PST
<rdar://problem/72771835>
Jonathan Bedard
Comment 3 2021-01-05 10:27:28 PST
Comment on attachment 416790 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=416790&action=review > Tools/Scripts/bisect-builds:209 > + platform = SystemHost().platform SystemHost is not free to instantiate (it runs some shell commands in the constructor, if I recall correctly), so we probably don't want to instantiate it twice. > Tools/Scripts/bisect-builds:214 > + return platform Pretty sure you want to return "platform.os_name", not the actual PlatformInfo object
Alexey Proskuryakov
Comment 4 2021-01-06 09:21:38 PST
Created attachment 417092 [details] proposed patch Thank you, updated accordingly.
EWS
Comment 5 2021-01-06 12:31:49 PST
Committed r271211: <https://trac.webkit.org/changeset/271211> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417092 [details].
Note You need to log in before you can comment on or make changes to this bug.