Bug 220156

Summary: Remove one more place needed when adding new color types
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: Hironori.Fujii, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+, ews-feeder: commit-queue-
repro for the MSVC bug
none
Try not using a template-template parameter
ews-feeder: commit-queue-
Another attempt
none
For landing.
none
For Landing. none

Sam Weinig
Reported 2020-12-26 11:58:50 PST
Remove one more place needed when adding new color types
Attachments
Patch (1.91 KB, patch)
2020-12-26 11:59 PST, Sam Weinig 		simon.fraser: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
repro for the MSVC bug (1.78 KB, text/plain)
2020-12-26 14:43 PST, Fujii Hironori 		no flags
Details
Try not using a template-template parameter (1.86 KB, patch)
2020-12-26 14:56 PST, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Another attempt (1.79 KB, patch)
2020-12-26 19:24 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
For landing. (4.06 KB, patch)
2020-12-26 20:28 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
For Landing. (4.06 KB, patch)
2020-12-26 20:40 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-12-26 11:59:52 PST
Created attachment 416787 [details] Patch
Fujii Hironori
Comment 2 2020-12-26 14:43:12 PST
Created attachment 416791 [details] repro for the MSVC bug This seems a MSVC bug. I can't find out any workaround. Will report to MSVC team.
Sam Weinig
Comment 3 2020-12-26 14:55:03 PST
(In reply to Fujii Hironori from comment #2) > Created attachment 416791 [details] > repro for the MSVC bug > > This seems a MSVC bug. I can't find out any workaround. Will report to MSVC > team. Crazy, thanks so much. Let me know what you hear.
Sam Weinig
Comment 4 2020-12-26 14:56:33 PST
Created attachment 416792 [details] Try not using a template-template parameter
Sam Weinig
Comment 5 2020-12-26 15:13:02 PST
Comment on attachment 416792 [details] Try not using a template-template parameter Nope. Looks like that is far too permissive. Perhaps an std::enable_if can be used here.
Sam Weinig
Comment 6 2020-12-26 19:24:11 PST
Created attachment 416794 [details] Another attempt
Sam Weinig
Comment 7 2020-12-26 20:28:04 PST
Created attachment 416796 [details] For landing.
Sam Weinig
Comment 8 2020-12-26 20:40:09 PST
Created attachment 416798 [details] For Landing.
EWS
Comment 9 2020-12-27 10:00:37 PST
Committed r271093: <https://trac.webkit.org/changeset/271093> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416798 [details].
Radar WebKit Bug Importer
Comment 10 2020-12-27 10:01:19 PST
<rdar://problem/72690546>
Fujii Hironori
Comment 11 2021-01-06 23:32:09 PST
MSVC bug ticket: https://developercommunity2.visualstudio.com/t/template-specialization-reports-error-c2440-with-s/1296792 > A fix for this issue has been internally implemented and is being prepared for release. We’ll update you once it becomes available for download.
Fujii Hironori
Comment 12 2021-05-25 19:31:26 PDT
(In reply to Fujii Hironori from comment #11) > MSVC bug ticket: > https://developercommunity2.visualstudio.com/t/template-specialization-reports-error-c2440-with-s/1296792 > > > A fix for this issue has been internally implemented and is being prepared for release. We’ll update you once it becomes available for download. I got a report that Visual Studio 2019 version 16.10 fixed and I confirmed it fixed. BTW, I can't access the my MSVC bug ticket now.
Note You need to log in before you can comment on or make changes to this bug.