| Summary: | Remove one more place needed when adding new color types | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | Hironori.Fujii, simon.fraser, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Sam Weinig
2020-12-26 11:58:50 PST
Created attachment 416787 [details]
Patch
Created attachment 416791 [details]
repro for the MSVC bug
This seems a MSVC bug. I can't find out any workaround. Will report to MSVC team.
(In reply to Fujii Hironori from comment #2) > Created attachment 416791 [details] > repro for the MSVC bug > > This seems a MSVC bug. I can't find out any workaround. Will report to MSVC > team. Crazy, thanks so much. Let me know what you hear. Created attachment 416792 [details]
Try not using a template-template parameter
Comment on attachment 416792 [details]
Try not using a template-template parameter
Nope. Looks like that is far too permissive. Perhaps an std::enable_if can be used here.
Created attachment 416794 [details]
Another attempt
Created attachment 416796 [details]
For landing.
Created attachment 416798 [details]
For Landing.
Committed r271093: <https://trac.webkit.org/changeset/271093> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416798 [details]. MSVC bug ticket: https://developercommunity2.visualstudio.com/t/template-specialization-reports-error-c2440-with-s/1296792 > A fix for this issue has been internally implemented and is being prepared for release. We’ll update you once it becomes available for download. (In reply to Fujii Hironori from comment #11) > MSVC bug ticket: > https://developercommunity2.visualstudio.com/t/template-specialization-reports-error-c2440-with-s/1296792 > > > A fix for this issue has been internally implemented and is being prepared for release. We’ll update you once it becomes available for download. I got a report that Visual Studio 2019 version 16.10 fixed and I confirmed it fixed. BTW, I can't access the my MSVC bug ticket now. |