Bug 220123

Summary: Use sendWithAsyncReply instead of FontAttributesCallback
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2020-12-23 10:36:30 PST
Use sendWithAsyncReply instead of FontAttributesCallback
Attachments
Patch (8.68 KB, patch)
2020-12-23 10:36 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.65 KB, patch)
2020-12-23 10:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.81 KB, patch)
2021-01-05 09:45 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (8.22 KB, patch)
2021-01-05 10:33 PST, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-12-23 10:36:44 PST
Created attachment 416714 [details] Patch
Alex Christensen
Comment 2 2020-12-23 10:40:19 PST
Created attachment 416715 [details] Patch
Radar WebKit Bug Importer
Comment 3 2020-12-30 10:37:12 PST
<rdar://problem/72742140>
Chris Dumez
Comment 4 2021-01-05 08:40:42 PST
Comment on attachment 416715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416715&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:-2360 > - m_cachedFontAttributesAtSelectionStart = attributes; Looks like you are no longer updating m_cachedFontAttributesAtSelectionStart ?
Alex Christensen
Comment 5 2021-01-05 09:45:05 PST
Created attachment 417012 [details] Patch
Alex Christensen
Comment 6 2021-01-05 10:33:29 PST
Created attachment 417019 [details] Patch
Alex Christensen
Comment 7 2021-01-05 10:42:17 PST
http://trac.webkit.org/r271160
Note You need to log in before you can comment on or make changes to this bug.