Bug 220123

Summary:

Use sendWithAsyncReply instead of FontAttributesCallback

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	cdumez: review+

Description Alex Christensen 2020-12-23 10:36:30 PST

Use sendWithAsyncReply instead of FontAttributesCallback

Comment 1 Alex Christensen 2020-12-23 10:36:44 PST

Created attachment 416714 [details]
Patch

Comment 2 Alex Christensen 2020-12-23 10:40:19 PST

Created attachment 416715 [details]
Patch

Comment 3 Radar WebKit Bug Importer 2020-12-30 10:37:12 PST

<rdar://problem/72742140>

Comment 4 Chris Dumez 2021-01-05 08:40:42 PST

Comment on attachment 416715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416715&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:-2360
> -    m_cachedFontAttributesAtSelectionStart = attributes;

Looks like you are no longer updating m_cachedFontAttributesAtSelectionStart ?

Comment 5 Alex Christensen 2021-01-05 09:45:05 PST

Created attachment 417012 [details]
Patch

Comment 6 Alex Christensen 2021-01-05 10:33:29 PST

Created attachment 417019 [details]
Patch

Comment 7 Alex Christensen 2021-01-05 10:42:17 PST

http://trac.webkit.org/r271160