Bug 220101

Summary: Remove non-inclusive language from libwebrtc
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebRTCAssignee: youenn fablet <youennf>
Severity: Normal CC: aestes, bdakin, dino, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, simon.fraser, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/webrtc/issues/detail?id=11680
Bug Depends on:    
Bug Blocks: 213092    
Description Flags
Patch none

Description Beth Dakin 2020-12-22 13:22:36 PST
See results of 'report-non-inclusive-language --verbose' inside Source/ThirdParty/libwebrtc/Source/webrtc below. I took a look at https://webrtc.googlesource.com/src, and it's only marginally improved, with 84 occurrences of non-inclusive terms down from 93, so updating to a newer libwebrtc will only get us so far. We should try to make changes upstream as well.

.gn: whitelist: 2
tools_webrtc/vim/webrtc.ycm_extra_conf.py: whitelist: 1
tools_webrtc/msan/suppressions.txt: blacklist: 2
tools_webrtc/ubsan/vptr_suppressions.txt: blacklist: 5
tools_webrtc/ubsan/suppressions.txt: blacklist: 2
rtc_base/message_digest.h: whitelist: 1
rtc_base/win/windows_version.h: blacklist: 1
build_overrides/build.gni: blacklist: 3
sdk/android/api/org/webrtc/MediaCodecVideoEncoder.java: blacklist: 1
sdk/android/api/org/webrtc/HardwareVideoDecoderFactory.java: blacklist: 2
sdk/android/api/org/webrtc/PlatformSoftwareVideoDecoderFactory.java: whitelist: 2
sdk/android/src/java/org/webrtc/audio/WebRtcAudioEffects.java: blacklist: 2
sdk/android/src/jni/audio_device/audio_device_module.cc: blacklist: 2
modules/audio_device/android/audio_manager.h: blacklist: 3
modules/audio_device/android/audio_manager.cc: blacklist: 7
modules/audio_device/android/audio_device_template.h: blacklist: 3
modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java: blacklist: 16
modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java: blacklist: 16
modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java: blacklist: 18
logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc: whitelist: 4
Total: 93 (blacklist: 83, whitelist: 10, slave: 0)
Comment 1 Radar WebKit Bug Importer 2020-12-29 13:23:11 PST
Comment 2 youenn fablet 2021-01-04 07:57:03 PST
We can remove the sdk/android and modules/audio_device/android folders
Comment 3 Beth Dakin 2021-01-04 13:54:46 PST
(In reply to youenn fablet from comment #2)
> We can remove the sdk/android and modules/audio_device/android folders

Oh, that's a good idea!
Comment 4 youenn fablet 2021-01-05 03:19:49 PST
Related upstream issue is https://bugs.chromium.org/p/webrtc/issues/detail?id=11680
Comment 5 youenn fablet 2021-01-05 03:20:06 PST
Created attachment 416986 [details]
Comment 6 youenn fablet 2021-01-05 04:56:03 PST
Patch removes corresponding files except for rtc_base/message_digest.h.
I added a comment about this file in https://bugs.chromium.org/p/webrtc/issues/detail?id=11680
Comment 7 Beth Dakin 2021-01-05 09:35:58 PST
Comment on attachment 416986 [details]

All red patch, how exciting! Thanks Youenn!
Comment 8 youenn fablet 2021-01-05 09:44:53 PST
Comment on attachment 416986 [details]

Last remaining instance is being fixed upstream. I'll cherry pick the change when it lands upstream
Comment 9 EWS 2021-01-05 09:55:54 PST
Committed r271150: <https://trac.webkit.org/changeset/271150>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416986 [details].
Comment 10 Simon Fraser (smfr) 2021-01-05 10:15:21 PST
The patch that landed had some additional new logging in it.
Comment 11 youenn fablet 2021-01-05 10:31:50 PST
(In reply to Simon Fraser (smfr) from comment #10)
> The patch that landed had some additional new logging in it.

Thanks, I will revert them.
Comment 12 youenn fablet 2021-01-06 02:27:51 PST
Reopening to attach new patch.
Comment 13 youenn fablet 2021-01-06 02:27:54 PST
Created attachment 417076 [details]
Comment 14 EWS 2021-01-07 00:10:51 PST
Committed r271227: <https://trac.webkit.org/changeset/271227>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417076 [details].