Bug 220082

Summary: [CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
Product: WebKit Reporter: monson <holymonson>
Component: CMakeAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, ews-watchlist, fujii.hironori, gyuyoung.kim, ryuan.choi, sergio, smoley, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

monson
Reported 2020-12-22 02:17:27 PST
[CMake] Fix seperated include dir of harfbuzz and harfbuzz-icu
Attachments
Patch (2.11 KB, patch)
2020-12-22 02:28 PST, monson 		no flags
DetailsFormatted DiffDiff
Patch (2.21 KB, patch)
2020-12-23 04:12 PST, monson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
monson
Comment 1 2020-12-22 02:28:08 PST
Created attachment 416657 [details] Patch In some distros (NixOS) harfbuzz and harfbuzz-icu may have different include dir.
Radar WebKit Bug Importer
Comment 2 2020-12-22 11:18:19 PST
<rdar://problem/72593922>
Fujii Hironori
Comment 3 2020-12-22 19:53:48 PST
Comment on attachment 416657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416657&action=review LGTM. > ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Could you add your comment#2 in the ChangeLog?
monson
Comment 4 2020-12-23 04:12:39 PST
Created attachment 416708 [details] Patch
EWS
Comment 5 2020-12-23 08:53:22 PST
Committed r271069: <https://trac.webkit.org/changeset/271069> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416708 [details].
Note You need to log in before you can comment on or make changes to this bug.