Bug 220078

Summary:

Remove non-inclusive language from WebGL tests

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Tools / Tests

Assignee:

Beth Dakin <bdakin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bdakin, dino, ggaren, kbr, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

213092

Attachments:

Description	Flags
Patch	achristensen: review+
Patch	none

Description Beth Dakin 2020-12-21 16:22:07 PST

There is some non-inclusive language in WebGL tests that can be easily changed.

Comment 1 Beth Dakin 2020-12-21 16:24:09 PST

Created attachment 416643 [details]
Patch

Comment 2 Beth Dakin 2020-12-21 16:25:11 PST

Kenneth Russell: Is this something we can upstream?

Comment 3 Alex Christensen 2020-12-21 16:29:20 PST

Comment on attachment 416643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416643&action=review

> LayoutTests/webgl/2.0.0/resources/webgl_test_files/conformance2/vertex_arrays/vertex-array-object.html:-1
> -ï»¿<!--

BOM may as well stay.

Comment 4 Beth Dakin 2020-12-21 16:36:34 PST

(In reply to Alex Christensen from comment #3)
> Comment on attachment 416643 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416643&action=review
> 
> > LayoutTests/webgl/2.0.0/resources/webgl_test_files/conformance2/vertex_arrays/vertex-array-object.html:-1
> > -ï»¿<!--
> 
> BOM may as well stay.

The moment I made any changes in Xcode to other lines of this file, this change happens automatically. Any idea what is going on there?

Comment 5 Beth Dakin 2020-12-21 16:48:22 PST

Created attachment 416644 [details]
Patch

vi to the rescue

Comment 6 EWS 2020-12-21 21:20:28 PST

Committed r271048: <https://trac.webkit.org/changeset/271048>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416644 [details].

Comment 7 Radar WebKit Bug Importer 2020-12-21 21:21:17 PST

<rdar://problem/72573807>

Comment 8 Dean Jackson 2020-12-22 09:35:30 PST

I filed https://github.com/KhronosGroup/WebGL/issues/3197 on WebGL.

Comment 9 Kenneth Russell 2020-12-22 15:36:13 PST

(In reply to Beth Dakin from comment #2)
> Kenneth Russell: Is this something we can upstream?

Yes, certainly. Thanks Dean for filing the upstream bug.