Bug 220075

Summary: Layout overflow is computed incorrectly inside flexbox (breaks sticky positioning)
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=116689
Attachments:
Description Flags
Testcase
none
Patch none

Simon Fraser (smfr)
Reported 2020-12-21 15:42:07 PST
Created attachment 416639 [details] Testcase In the attached testcase, the sticky element gets pushed out of view as you scroll down and should not. In RenderBoxModelObject::computeStickyPositionConstraints(), containingBlock->layoutOverflowRect() returns a rect that is too short, but only when inside flex layout.
Attachments
Testcase (683 bytes, text/html)
2020-12-21 15:42 PST, Simon Fraser (smfr) 		no flags
Details
Patch (4.64 KB, patch)
2020-12-21 19:58 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-12-21 15:43:00 PST
<rdar://problem/70956639>
Simon Fraser (smfr)
Comment 2 2020-12-21 19:58:36 PST
Created attachment 416648 [details] Patch
EWS
Comment 3 2020-12-22 08:09:28 PST
Committed r271053: <https://trac.webkit.org/changeset/271053> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416648 [details].
Note You need to log in before you can comment on or make changes to this bug.