| Summary: | Layout overflow is computed incorrectly inside flexbox (breaks sticky positioning) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, clopez, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=116689 | ||||||||
| Attachments: |
|
||||||||
Created attachment 416648 [details]
Patch
Committed r271053: <https://trac.webkit.org/changeset/271053> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416648 [details]. |
Created attachment 416639 [details] Testcase In the attached testcase, the sticky element gets pushed out of view as you scroll down and should not. In RenderBoxModelObject::computeStickyPositionConstraints(), containingBlock->layoutOverflowRect() returns a rect that is too short, but only when inside flex layout.