Bug 220058

Summary: Unmuting a track in case of end of interruption by another web process tab is not working well with capture muting icons
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: REOPENED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kangil.han, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220591    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2020-12-21 09:23:32 PST
Unmuting a track in case of end of interruption by another web process tab is not working well with capture muting icons
Attachments
Patch (16.09 KB, patch)
2020-12-21 09:58 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (20.33 KB, patch)
2021-01-05 05:48 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (19.73 KB, patch)
2021-01-12 05:09 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-12-21 09:58:05 PST
Created attachment 416606 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-12-28 09:24:12 PST
<rdar://problem/72705675>
youenn fablet
Comment 3 2021-01-05 05:48:53 PST
Created attachment 416998 [details] Patch
Eric Carlson
Comment 4 2021-01-11 14:25:06 PST
Comment on attachment 416998 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416998&action=review > Source/WebCore/ChangeLog:20 > + When an interruption ends, all capture tracks are updated accorsing the page muted state, which is controlled by UIProcess. s/updated accorsing the page/updated according to the page/ > Source/WebKit/ChangeLog:172 > -2020-12-22 Youenn Fablet <youenn@apple.com> > +2020-12-21 Youenn Fablet <youenn@apple.com> Is this change intentional? > Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp:487 > + // We can only have one source at a time: we can mute all tracks but unmute only one of them. Nit: this and the comment below are duplicated in the audio and video loops, they could be moved up above instead.
youenn fablet
Comment 5 2021-01-12 05:09:55 PST
Created attachment 417445 [details] Patch for landing
EWS
Comment 6 2021-01-12 06:34:33 PST
Committed r271401: <https://trac.webkit.org/changeset/271401> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417445 [details].
WebKit Commit Bot
Comment 7 2021-01-13 07:52:01 PST
Re-opened since this is blocked by bug 220591
Note You need to log in before you can comment on or make changes to this bug.