Bug 220047

Summary: Simplify CARingBuffer usage with SharedMemory storage
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Chris Dumez
Reported 2020-12-20 15:56:30 PST
Simplify CARingBuffer usage with SharedMemory storage.
Attachments
Patch (24.52 KB, patch)
2020-12-20 16:02 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.72 KB, patch)
2020-12-21 12:09 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-12-20 16:02:31 PST
Created attachment 416589 [details] Patch
Geoffrey Garen
Comment 2 2020-12-21 10:18:39 PST
Comment on attachment 416589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416589&action=review r=me > Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp:40 > +void* ReadOnlySharedRingBufferStorage::data() const void*? > Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp:45 > +auto ReadOnlySharedRingBufferStorage::sharedFrameBounds() const -> FrameBounds* const FrameBounds*?
Chris Dumez
Comment 3 2020-12-21 12:09:59 PST
Created attachment 416617 [details] Patch
EWS
Comment 4 2020-12-21 14:32:02 PST
Committed r271041: <https://trac.webkit.org/changeset/271041> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416617 [details].
Radar WebKit Bug Importer
Comment 5 2020-12-21 14:33:30 PST
<rdar://problem/72562577>
Note You need to log in before you can comment on or make changes to this bug.