Bug 220047

Summary: Simplify CARingBuffer usage with SharedMemory storage
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Description Chris Dumez 2020-12-20 15:56:30 PST 
Simplify CARingBuffer usage with SharedMemory storage.
Comment 1 Chris Dumez 2020-12-20 16:02:31 PST 
Created attachment 416589 [details]
Patch
Comment 2 Geoffrey Garen 2020-12-21 10:18:39 PST 
Comment on attachment 416589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416589&action=review

r=me

> Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp:40
> +void* ReadOnlySharedRingBufferStorage::data()

const void*?

> Source/WebKit/Shared/Cocoa/SharedRingBufferStorage.cpp:45
> +auto ReadOnlySharedRingBufferStorage::sharedFrameBounds() const -> FrameBounds*

const FrameBounds*?
Comment 3 Chris Dumez 2020-12-21 12:09:59 PST 
Created attachment 416617 [details]
Patch
Comment 4 EWS 2020-12-21 14:32:02 PST 
Committed r271041: <https://trac.webkit.org/changeset/271041>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416617 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-21 14:33:30 PST 
<rdar://problem/72562577>