| Summary: | [macOS] Deny mach-lookup to the service 'com.apple.iconservices.store' in the WebContent process | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||
| Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, bfulgham, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Per Arne Vollan
2020-12-18 06:51:21 PST
Created attachment 416515 [details]
Patch
Comment on attachment 416515 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416515&action=review > Source/WebKit/ChangeLog:10 > + since there are no longer any reports of this being used. Out of curiosity, how do we get icons for file input form controls now? (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 416515 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416515&action=review > > > Source/WebKit/ChangeLog:10 > > + since there are no longer any reports of this being used. > > Out of curiosity, how do we get icons for file input form controls now? We are creating extensions for the open file dialog. Is that the case you’re thinking of? Thanks for reviewing! Created attachment 416538 [details]
Patch
> We are creating extensions for the open file dialog. Is that the case you’re
> thinking of?
No, I was thinking about attachment icons in form controls, which would be visible *after* selecting a file in the dialog. But checking the current behavior, I don't see it in the build of Safari that I have. I don't remember when I last saw it work. Perhaps we broke this intentionally, and/or a long time ago?
Bug 190384 says that attachment icons were incorrect in a specific case, which implies that they were shown at the time in 2018 I think. (In reply to Alexey Proskuryakov from comment #7) > Bug 190384 says that attachment icons were incorrect in a specific case, > which implies that they were shown at the time in 2018 I think. Got it, thanks! I can test if the service is being accessed in this case. Comment on attachment 416538 [details]
Patch
r=me
Committed r271778: <https://trac.webkit.org/changeset/271778> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416538 [details]. |