Bug 220008

Summary: Add tagging to JIT probe's return address.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. keith_miller: review+

Mark Lam
Reported 2020-12-17 23:30:26 PST
rdar://71279530
Attachments
proposed patch. (7.39 KB, patch)
2020-12-17 23:35 PST, Mark Lam 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2020-12-17 23:35:32 PST
Created attachment 416500 [details] proposed patch.
Robin Morisset
Comment 2 2020-12-18 08:42:37 PST
Comment on attachment 416500 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=416500&action=review LGTM, but I don't understand this code well enough to r+ it. > Source/JavaScriptCore/assembler/MacroAssemblerARM64.cpp:524 > + "sub x27, x27, #" STRINGIZE_VALUE_OF(2 * GPREG_SIZE) "\n" // The retun point PC is at 2 instructions before the end of the probe. retun -> return
Keith Miller
Comment 3 2020-12-18 10:58:33 PST
Comment on attachment 416500 [details] proposed patch. r=me
Mark Lam
Comment 4 2020-12-18 11:27:03 PST
Thanks for the reviews. Landed in r270981: <http://trac.webkit.org/r270981>.
Note You need to log in before you can comment on or make changes to this bug.