Bug 220003

Summary: Gate all of the code associated with app highlights
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kangil.han, kondapallykalyan, pdr, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2020-12-17 19:34:11 PST
Gate all of the code associated with app highlights
Attachments
Patch (23.59 KB, patch)
2020-12-17 19:40 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (23.73 KB, patch)
2020-12-17 19:57 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (23.72 KB, patch)
2020-12-18 09:32 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2020-12-17 19:40:02 PST
Created attachment 416491 [details] Patch
Megan Gardner
Comment 2 2020-12-17 19:40:33 PST
<rdar://problem/72451893>
Tim Horton
Comment 3 2020-12-17 19:43:00 PST
Comment on attachment 416491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416491&action=review > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:57 > humanReadableDescription: "Enable persistant highlights for apps" While here, please “persistent” > Source/WebCore/rendering/RenderTheme.h:165 > +#if ENABLE(APP_HIGHLIGHTS) Definitely recommend moving this up a line
Megan Gardner
Comment 4 2020-12-17 19:57:37 PST
Created attachment 416493 [details] Patch
Megan Gardner
Comment 5 2020-12-18 09:32:12 PST
Created attachment 416525 [details] Patch for landing
EWS
Comment 6 2020-12-18 10:25:58 PST
Committed r270974: <https://trac.webkit.org/changeset/270974> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416525 [details].
Note You need to log in before you can comment on or make changes to this bug.