Summary: | [macOS] Use low-power audio buffer sizes for more output devices | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jer Noble
2020-12-16 21:38:52 PST
Created attachment 416388 [details]
Patch
Created attachment 416392 [details]
Patch
Comment on attachment 416392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416392&action=review > Source/WebCore/platform/audio/AudioHardwareListener.cpp:42 > + m_supportedBufferSizes = { 32, 4096 }; Can you initialize this in the header? > Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:72 > + return { 0, 0 }; Wouldn't `return { }` do the same? > Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:84 > + return { 0, 0 }; Ditto. (In reply to Eric Carlson from comment #4) > Comment on attachment 416392 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416392&action=review > > > Source/WebCore/platform/audio/AudioHardwareListener.cpp:42 > > + m_supportedBufferSizes = { 32, 4096 }; > > Can you initialize this in the header? I didn't really want to put a conditional variable initializer in the header. > > Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:72 > > + return { 0, 0 }; > > Wouldn't `return { }` do the same? Probably! > > Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:84 > > + return { 0, 0 }; > > Ditto. Created attachment 416441 [details]
Patch for landing
Committed r270943: <https://trac.webkit.org/changeset/270943> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416441 [details]. |