Bug 219970

Summary: [CMake] Unify WebGL source files into the common WebCore/CMakeLists.txt
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: CMakeAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, cmarcelo, dino, don.olmstead, ews-watchlist, graouts, gyuyoung.kim, kkinnunen, kondapallykalyan, luiz, pvollan, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch don.olmstead: review+

Fujii Hironori
Reported 2020-12-16 18:25:31 PST
[CMake] Unify WebGL source files into the common WebCore/CMakeLists.txt As per the discussion with Kimmo (Bug 219421 Comment 15), CMake should have a single place to list WebGL source files.
Attachments
Patch (12.08 KB, patch)
2020-12-16 18:33 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (12.11 KB, patch)
2020-12-16 19:07 PST, Fujii Hironori 		don.olmstead: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-12-16 18:33:39 PST
Created attachment 416379 [details] Patch
Fujii Hironori
Comment 2 2020-12-16 19:07:28 PST
Created attachment 416380 [details] Patch
Don Olmstead
Comment 3 2020-12-17 10:55:06 PST
Comment on attachment 416380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416380&action=review > Source/WebCore/ChangeLog:15 > + GraphicsContextGLOpenGLPrivate is used only by AppleWin port. > + Enclosed by #if PLATFORM(WIN) && USE(CA). AppleWin explicitly disables WebGL, https://github.com/WebKit/WebKit/blob/main/Source/cmake/OptionsWin.cmake#L97 , so you should be able to further simplify.
Fujii Hironori
Comment 4 2020-12-17 11:46:45 PST
Comment on attachment 416380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416380&action=review >> Source/WebCore/ChangeLog:15 >> + Enclosed by #if PLATFORM(WIN) && USE(CA). > > AppleWin explicitly disables WebGL, https://github.com/WebKit/WebKit/blob/main/Source/cmake/OptionsWin.cmake#L97 , so you should be able to further simplify. Yup. It should be separated into a new file. However, I'm not interested in refactoring the dead code. If AppleWin will re-enable it, I will do that.
Fujii Hironori
Comment 5 2020-12-17 11:48:31 PST
Per mentioned reenabling WebGL in the Slack. > Per Arne Vollan 03:23 > @fujihiro I think it would be good to keep, if it will be renabled at one point. https://webkit.slack.com/archives/CU84Q46JZ/p1608229381029100
Don Olmstead
Comment 6 2020-12-17 12:15:27 PST
(In reply to Fujii Hironori from comment #5) > Per mentioned reenabling WebGL in the Slack. > > Per Arne Vollan 03:23 > > @fujihiro I think it would be good to keep, if it will be renabled at one point. > https://webkit.slack.com/archives/CU84Q46JZ/p1608229381029100 Ok I don't honestly think it'll be reenabled but that shouldn't block this patch.
Fujii Hironori
Comment 7 2020-12-17 12:20:37 PST
Thanks, Don. But, I don't agree. There is a strong market demand resurrecting Safari for Windows. They will have to do that 👍
Fujii Hironori
Comment 8 2020-12-17 12:31:18 PST
Committed r270940: <https://trac.webkit.org/changeset/270940>
Note You need to log in before you can comment on or make changes to this bug.