| Summary: | [CMake] Unify WebGL source files into the common WebCore/CMakeLists.txt | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
| Component: | CMake | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, annulen, bfulgham, cmarcelo, dino, don.olmstead, ews-watchlist, graouts, gyuyoung.kim, kkinnunen, kondapallykalyan, luiz, pvollan, ryuan.choi, sergio | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Fujii Hironori
2020-12-16 18:25:31 PST
Created attachment 416379 [details]
Patch
Created attachment 416380 [details]
Patch
Comment on attachment 416380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416380&action=review > Source/WebCore/ChangeLog:15 > + GraphicsContextGLOpenGLPrivate is used only by AppleWin port. > + Enclosed by #if PLATFORM(WIN) && USE(CA). AppleWin explicitly disables WebGL, https://github.com/WebKit/WebKit/blob/main/Source/cmake/OptionsWin.cmake#L97 , so you should be able to further simplify. Comment on attachment 416380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416380&action=review >> Source/WebCore/ChangeLog:15 >> + Enclosed by #if PLATFORM(WIN) && USE(CA). > > AppleWin explicitly disables WebGL, https://github.com/WebKit/WebKit/blob/main/Source/cmake/OptionsWin.cmake#L97 , so you should be able to further simplify. Yup. It should be separated into a new file. However, I'm not interested in refactoring the dead code. If AppleWin will re-enable it, I will do that. Per mentioned reenabling WebGL in the Slack. > Per Arne Vollan 03:23 > @fujihiro I think it would be good to keep, if it will be renabled at one point. https://webkit.slack.com/archives/CU84Q46JZ/p1608229381029100 (In reply to Fujii Hironori from comment #5) > Per mentioned reenabling WebGL in the Slack. > > Per Arne Vollan 03:23 > > @fujihiro I think it would be good to keep, if it will be renabled at one point. > https://webkit.slack.com/archives/CU84Q46JZ/p1608229381029100 Ok I don't honestly think it'll be reenabled but that shouldn't block this patch. Thanks, Don. But, I don't agree. There is a strong market demand resurrecting Safari for Windows. They will have to do that 👍 Committed r270940: <https://trac.webkit.org/changeset/270940> |