Bug 219951

Summary: [GPUProcess] https://www.waveplayer.info/createmediaelementsource-test/ demo is flaky
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220609    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Chris Dumez 2020-12-16 10:06:50 PST 
https://www.waveplayer.info/createmediaelementsource-test/ demo is flaky. Sometimes the page claims audio is playing but nothing can be heard on the speakers. Pausing / resuming the song seems to fix the issue. I suspect some kind of initialization race.
Comment 1 Chris Dumez 2020-12-17 16:02:19 PST 
Created attachment 416478 [details]
Patch
Comment 2 Chris Dumez 2020-12-17 16:08:38 PST 
Created attachment 416479 [details]
Patch
Comment 3 Geoffrey Garen 2020-12-17 16:44:01 PST 
Comment on attachment 416479 [details]
Patch

r=me
Comment 4 Peng Liu 2020-12-17 16:45:57 PST 
Comment on attachment 416479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416479&action=review

> Source/WebCore/ChangeLog:33
> +        I also made the following changes to make the code simpler and to resume code

s/resume/reduce/

> Source/WebCore/ChangeLog:38
> +          storage changed and in all cases, it needs to provide this 2 parameters

s/this/these/
Comment 5 Chris Dumez 2020-12-17 16:51:34 PST 
Created attachment 416482 [details]
Patch
Comment 6 EWS 2020-12-17 17:22:07 PST 
Committed r270961: <https://trac.webkit.org/changeset/270961>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416482 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-17 17:23:20 PST 
<rdar://problem/72448152>