Bug 219951 - [GPUProcess] https://www.waveplayer.info/createmediaelementsource-test/ demo is flaky
Summary: [GPUProcess] https://www.waveplayer.info/createmediaelementsource-test/ demo ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 220609
Blocks:
  Show dependency tree / graph
 
Reported: 2020-12-16 10:06 PST by Chris Dumez
Modified: 2021-01-13 16:25 PST (History)
10 users (show)

See Also:

Attachments
Patch (42.50 KB, patch)
2020-12-17 16:02 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (42.53 KB, patch)
2020-12-17 16:08 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (42.53 KB, patch)
2020-12-17 16:51 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-12-16 10:06:50 PST 
https://www.waveplayer.info/createmediaelementsource-test/ demo is flaky. Sometimes the page claims audio is playing but nothing can be heard on the speakers. Pausing / resuming the song seems to fix the issue. I suspect some kind of initialization race.
Comment 1 Chris Dumez 2020-12-17 16:02:19 PST 
Created attachment 416478 [details]
Patch
Comment 2 Chris Dumez 2020-12-17 16:08:38 PST 
Created attachment 416479 [details]
Patch
Comment 3 Geoffrey Garen 2020-12-17 16:44:01 PST 
Comment on attachment 416479 [details]
Patch

r=me
Comment 4 Peng Liu 2020-12-17 16:45:57 PST 
Comment on attachment 416479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416479&action=review

> Source/WebCore/ChangeLog:33
> +        I also made the following changes to make the code simpler and to resume code

s/resume/reduce/

> Source/WebCore/ChangeLog:38
> +          storage changed and in all cases, it needs to provide this 2 parameters

s/this/these/
Comment 5 Chris Dumez 2020-12-17 16:51:34 PST 
Created attachment 416482 [details]
Patch
Comment 6 EWS 2020-12-17 17:22:07 PST 
Committed r270961: <https://trac.webkit.org/changeset/270961>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416482 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-17 17:23:20 PST 
<rdar://problem/72448152>