Bug 219929

Summary: destinationFor should check for FTLJIT, not DFGJIT twice
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Description Saam Barati 2020-12-15 16:50:09 PST
...
Comment 1 Saam Barati 2020-12-15 16:53:26 PST
Created attachment 416303 [details]
patch
Comment 2 Keith Miller 2020-12-15 17:35:23 PST
Comment on attachment 416303 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416303&action=review

> Source/JavaScriptCore/bytecode/BytecodeOperandsForCheckpoint.h:103
> +            if (type == JITType::DFGJIT || type == JITType::FTLJIT)

Nah that seems legit :P
Comment 3 Saam Barati 2020-12-15 17:40:27 PST
(In reply to Keith Miller from comment #2)
> Comment on attachment 416303 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416303&action=review
> 
> > Source/JavaScriptCore/bytecode/BytecodeOperandsForCheckpoint.h:103
> > +            if (type == JITType::DFGJIT || type == JITType::FTLJIT)
> 
> Nah that seems legit :P

:-)
Comment 4 EWS 2020-12-15 18:32:48 PST
Committed r270877: <https://trac.webkit.org/changeset/270877>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416303 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-15 18:33:17 PST
<rdar://problem/72366903>