Bug 219929

Summary:

destinationFor should check for FTLJIT, not DFGJIT twice

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Saam Barati

Reported 2020-12-15 16:50:09 PST

...

Attachments
patch (1.76 KB, patch) 2020-12-15 16:53 PST, Saam Barati	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2020-12-15 16:53:26 PST

Keith Miller

Comment 2 2020-12-15 17:35:23 PST

Comment on attachment 416303 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=416303&action=review > Source/JavaScriptCore/bytecode/BytecodeOperandsForCheckpoint.h:103 > + if (type == JITType::DFGJIT || type == JITType::FTLJIT) Nah that seems legit :P

Saam Barati

Comment 3 2020-12-15 17:40:27 PST

(In reply to Keith Miller from comment #2) > Comment on attachment 416303 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416303&action=review > > > Source/JavaScriptCore/bytecode/BytecodeOperandsForCheckpoint.h:103 > > + if (type == JITType::DFGJIT || type == JITType::FTLJIT) > > Nah that seems legit :P :-)

EWS

Comment 4 2020-12-15 18:32:48 PST

Committed r270877: <https://trac.webkit.org/changeset/270877> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416303 [details].

Radar WebKit Bug Importer

Comment 5 2020-12-15 18:33:17 PST

Note You need to log in before you can comment on or make changes to this bug.