Bug 219916 – [GTK] Missing header when ENABLE_GRAPHICS_CONTEXT_GL is set to OFF

• Component: WebKitGTK
• Status: RESOLVED INVALID

[Charlene Wendling]

Created attachment 416284 [details]
patch to include the missing header

Platform: OpenBSD macppc (32-bit, big endian)
Compiler: clang-10
Version: 2.30.3

Hi,

Colors are off when Context GL is enabled on my platform, as a workaround i've disabled it.

In Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp, the XVisualInfo struct and XGetVisualInfo(3) are used. They're defined in <X11/Xutil.h>,
but that header is not included, leading to a broken build.

The attached patch allows me to build WebKitGTK on my platform.

[Fujii Hironori]

Could you follow the contributing guideline?
https://webkit.org/contributing-code/

ENABLE_GRAPHICS_CONTEXT_GL was removed by Bug 219551. Did you check with the latest trunk?

[Charlene Wendling]

I have not tested with the latest trunk, sorry, but i've searched only for open bugs. Thanks for the contribution guideline (i've never reported a bug before here).

I will try against the latest trunk, but it requires dealing with more than 30 OS-specific patches. I'll report back if any issue arise.

[Fujii Hironori]

You can disable accelerated compositing by setting a env var.
WEBKIT_DISABLE_COMPOSITING_MODE=1
https://trac.webkit.org/wiki/EnvironmentVariables

(In reply to Charlene Wendling from comment #0)
> Colors are off when Context GL is enabled on my platform, as a workaround

Does you mean your browser shows a blank screen?
Do all OpenGL apps show the blank screen on your platform?
Or, only WebKitGTK has the issue?

[Charlene Wendling]

Created attachment 416319 [details]
Screenshot of WebkitGTK badly rendering colors

[Charlene Wendling]

Only WebKitGTK has this issue(In reply to Fujii Hironori from comment #3)
> You can disable accelerated compositing by setting a env var.
> WEBKIT_DISABLE_COMPOSITING_MODE=1
> https://trac.webkit.org/wiki/EnvironmentVariables
> 
> (In reply to Charlene Wendling from comment #0)
> > Colors are off when Context GL is enabled on my platform, as a workaround
> 
> Does you mean your browser shows a blank screen?
> Do all OpenGL apps show the blank screen on your platform?
> Or, only WebKitGTK has the issue?

Only WebKitGTK has the issue. I attached a screenshot to give you an overview of what is going on.