Bug 21989

Summary: Merge PropertyMap and StructureID
Product: WebKit Reporter: Sam Weinig <sam>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
patch zwarich: review+

Sam Weinig
Reported 2008-10-30 16:11:24 PDT
Patch forthcoming.
Attachments
patch (75.55 KB, patch)
2008-10-30 16:17 PDT, Sam Weinig 		zwarich: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2008-10-30 16:17:01 PDT
Created attachment 24785 [details] patch
Cameron Zwarich (cpst)
Comment 2 2008-10-30 16:23:53 PDT
Comment on attachment 24785 [details] patch You have an extra newline at the beginning of StructureID.h. Other than that, r=me.
Geoffrey Garen
Comment 3 2008-10-30 16:29:17 PDT
I don't think the rename to "checkConsistencyOfPropertyMapHashTable" is an improvement. Other than that, r=me.
Cameron Zwarich (cpst)
Comment 4 2008-10-30 17:09:00 PDT
Comment on attachment 24785 [details] patch I should actually set the review flag, but I agree with Geoff's comment.
Sam Weinig
Comment 5 2008-10-30 17:13:09 PDT
Landed in r38016.
Note You need to log in before you can comment on or make changes to this bug.