Bug 219878

Summary: Add batching to WebPreferences updates
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit Misc.Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Simon Fraser (smfr)
Reported 2020-12-14 16:08:16 PST
Add batching to WebPreferences updates
Attachments
Patch (5.57 KB, patch)
2020-12-14 16:09 PST, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-12-14 16:09:24 PST
Created attachment 416202 [details] Patch
Sam Weinig
Comment 2 2020-12-15 08:24:56 PST
Comment on attachment 416202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416202&action=review Very nice. I will probably extend this to add SPI to do this to make the tests a bit more efficient. > Source/WebKit/UIProcess/WebPreferences.h:46 > + friend class ChangeBatch; I think you can put this right next to the ChangeBatch declaration to keep things a bit tidier.
Simon Fraser (smfr)
Comment 3 2020-12-15 10:17:07 PST
https://trac.webkit.org/changeset/270851/webkit
Radar WebKit Bug Importer
Comment 4 2020-12-15 10:18:19 PST
<rdar://problem/72347345>
Note You need to log in before you can comment on or make changes to this bug.