| Summary: | Simplify transform blending for simple cases | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2020-12-14 11:11:23 PST
Created attachment 416176 [details]
Patch
Comment on attachment 416176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416176&action=review > Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:952 > + if (!fmod(angle, 360)) std::fmod or std::fmod<double> > Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1675 > + for (size_t x = 0; x < 4; ++x) { > + for (size_t y = 0; y < 4; ++y) > + m_matrix[x][y] = from.m_matrix[x][y]; > + } You can just do *this = from here. (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 416176 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=416176&action=review > > > Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:952 > > + if (!fmod(angle, 360)) > > std::fmod or std::fmod<double> Will fix in commit. > > Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1675 > > + for (size_t x = 0; x < 4; ++x) { > > + for (size_t y = 0; y < 4; ++y) > > + m_matrix[x][y] = from.m_matrix[x][y]; > > + } > > You can just do *this = from here. That's excellent, I was hoping there was a better way! Committed r270801: <https://trac.webkit.org/changeset/270801> |