Bug 219806

Summary: Web Inspector: Add icon for collapsed blackboxed section
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 216897    
Bug Blocks: 234581    
Attachments:
Description Flags
Patch
none
[Image] after Patch is applied (dark)
none
[Image] after Patch is applied (light) none

Nikita Vasilyev
Reported 2020-12-11 15:05:07 PST
Could be a literal black box, could be something else.
Attachments
Patch (2.89 KB, patch)
2022-01-04 12:22 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] after Patch is applied (dark) (1.31 MB, image/png)
2022-01-04 12:24 PST, Devin Rousso 		no flags
Details
[Image] after Patch is applied (light) (1.28 MB, image/png)
2022-01-04 12:24 PST, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-11 15:05:20 PST
<rdar://problem/72240360>
Nikita Vasilyev
Comment 2 2021-01-14 09:45:40 PST
No icons needs to be added if you use the existing `[?]` icon, which is my current plan. I’ll reopen if we decide to use another icon.
Devin Rousso
Comment 3 2021-12-22 12:55:55 PST
I don't think [?] is a good icon to convey "blackboxed". I think we should either use the eye or some other icon so that it's visually clear that the blackboxed "group" is not a normal call frame.
Devin Rousso
Comment 4 2022-01-04 12:22:53 PST
Created attachment 448319 [details] Patch
Devin Rousso
Comment 5 2022-01-04 12:24:16 PST
Created attachment 448321 [details] [Image] after Patch is applied (dark)
Devin Rousso
Comment 6 2022-01-04 12:24:34 PST
Created attachment 448322 [details] [Image] after Patch is applied (light)
Joseph Pecoraro
Comment 7 2022-01-04 12:27:46 PST
Comment on attachment 448319 [details] Patch Neat! Looks nice
Patrick Angle
Comment 8 2022-01-04 13:10:28 PST
Comment on attachment 448319 [details] Patch r=me
EWS
Comment 9 2022-01-04 13:44:06 PST
Committed r287586 (245715@main): <https://commits.webkit.org/245715@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448319 [details].
Note You need to log in before you can comment on or make changes to this bug.