Bug 219803

Summary: [webkitscmpy] Load mock repository data from json file
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219602
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-12-11 13:19:58 PST
As per a discussion Stephanie and I had in https://bugs.webkit.org/show_bug.cgi?id=219602, we should pull the mock data from inside the mock objects and put it in json files.
Attachments
Patch (29.98 KB, patch)
2020-12-11 13:43 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (30.68 KB, patch)
2020-12-11 13:53 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (30.71 KB, patch)
2020-12-14 07:39 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-11 13:20:40 PST
<rdar://problem/72236132>
Jonathan Bedard
Comment 2 2020-12-11 13:43:14 PST
Created attachment 416039 [details] Patch
Jonathan Bedard
Comment 3 2020-12-11 13:53:56 PST
Created attachment 416043 [details] Patch
Stephanie Lewis
Comment 4 2020-12-11 15:22:36 PST
Comment on attachment 416043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416043&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:35 > + self, path='/.invalid-git', data=None, nit: data to me implies that the file has already been read
Jonathan Bedard
Comment 5 2020-12-14 07:39:13 PST
Created attachment 416155 [details] Patch for landing
EWS
Comment 6 2020-12-14 08:34:57 PST
Committed r270769: <https://trac.webkit.org/changeset/270769> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416155 [details].
Note You need to log in before you can comment on or make changes to this bug.