Bug 219743

Summary: [CMake] Use TARGET_PROPERTY to set includes for executables
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, Hironori.Fujii, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Don Olmstead
Reported 2020-12-10 07:46:19 PST
...
Attachments
Patch (5.53 KB, patch)
2020-12-10 07:55 PST, Don Olmstead 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-12-10 07:55:56 PST
Created attachment 415875 [details] Patch
EWS
Comment 2 2020-12-10 10:08:43 PST
Committed r270634: <https://trac.webkit.org/changeset/270634> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415875 [details].
Fujii Hironori
Comment 3 2020-12-10 13:40:58 PST
I don't prefer the idea using CMake's generator expressions unnecessarily. Using normal variables is straightforward.
Note You need to log in before you can comment on or make changes to this bug.