Bug 219743 - [CMake] Use TARGET_PROPERTY to set includes for executables
Summary: [CMake] Use TARGET_PROPERTY to set includes for executables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-10 07:46 PST by Don Olmstead
Modified: 2020-12-10 13:40 PST (History)
12 users (show)

See Also:

Attachments
Patch (5.53 KB, patch)
2020-12-10 07:55 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-12-10 07:46:19 PST 
...
Comment 1 Don Olmstead 2020-12-10 07:55:56 PST 
Created attachment 415875 [details]
Patch
Comment 2 EWS 2020-12-10 10:08:43 PST 
Committed r270634: <https://trac.webkit.org/changeset/270634>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415875 [details].
Comment 3 Fujii Hironori 2020-12-10 13:40:58 PST 
I don't prefer the idea using CMake's generator expressions unnecessarily. Using normal variables is straightforward.