Bug 219688

Summary: Pass an isolated copy of Settings to workers and worklets.
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kangil.han, keith_miller, mark.lam, msaboff, philipj, saam, sam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 219252, 267196    
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2020-12-09 08:32:51 PST
Pass an isolated copy of Settings to workers and worklets.
Attachments
Patch (33.98 KB, patch)
2020-12-09 08:49 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (29.48 KB, patch)
2020-12-14 00:21 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-12-09 08:49:46 PST
Created attachment 415763 [details] Patch
Sam Weinig
Comment 2 2020-12-13 08:36:28 PST
Comment on attachment 415763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415763&action=review This is fantastic work! Thanks Youenn! > Source/WebCore/ChangeLog:10 > + > + Generate a Settings::Values struct containing all setting values. > + Workers and worklets get that structure from their document and do a thread safe copy to use it in the background thread. > + Covered by existing tests in workers. Got a case of the double ChangeLogs.
youenn fablet
Comment 3 2020-12-14 00:21:04 PST
Created attachment 416139 [details] Patch for landing
EWS
Comment 4 2020-12-14 01:44:22 PST
Committed r270762: <https://trac.webkit.org/changeset/270762> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416139 [details].
Radar WebKit Bug Importer
Comment 5 2020-12-14 01:45:19 PST
<rdar://problem/72288687>
Note You need to log in before you can comment on or make changes to this bug.