Bug 219669

Summary: WebGL context screen change events should work with GPU process
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, pvollan, rini_patel, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 223121    
Bug Blocks: 217211    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Kimmo Kinnunen
Reported 2020-12-08 23:06:51 PST
WebGL context screen change events should work with GPU process
Attachments
Patch (12.51 KB, patch)
2021-03-04 03:49 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (14.82 KB, patch)
2021-03-04 05:43 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (14.79 KB, patch)
2021-03-05 04:27 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (14.69 KB, patch)
2021-03-07 23:10 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-15 23:07:15 PST
<rdar://problem/72373371>
Kimmo Kinnunen
Comment 2 2021-03-04 03:49:39 PST
Created attachment 422213 [details] Patch
Kimmo Kinnunen
Comment 3 2021-03-04 05:43:02 PST
Created attachment 422217 [details] Patch
Jon Lee
Comment 4 2021-03-04 09:57:35 PST
*** Bug 220806 has been marked as a duplicate of this bug. ***
Kimmo Kinnunen
Comment 5 2021-03-04 12:06:49 PST
*** Bug 219349 has been marked as a duplicate of this bug. ***
Per Arne Vollan
Comment 6 2021-03-04 12:53:22 PST
Comment on attachment 422217 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422217&action=review R=me. > Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:102 > + protectedThis->m_context->displayWasReconfigured(); Will this be thread safe?
Kimmo Kinnunen
Comment 7 2021-03-04 23:27:23 PST
(In reply to Per Arne Vollan from comment #6) > > Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:102 > > + protectedThis->m_context->displayWasReconfigured(); > > Will this be thread safe? Yes, the m_context parts are the parts that get run in the work queue.
Kimmo Kinnunen
Comment 8 2021-03-05 04:27:56 PST
Created attachment 422363 [details] Patch
Kimmo Kinnunen
Comment 9 2021-03-07 23:10:58 PST
Created attachment 422545 [details] Patch
EWS
Comment 10 2021-03-08 01:37:31 PST
Committed r274065: <https://commits.webkit.org/r274065> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422545 [details].
Note You need to log in before you can comment on or make changes to this bug.