Bug 219662

Summary: Fix for focus tracking in isolated tree mode.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: New BugsAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andres Gonzalez 2020-12-08 18:07:12 PST
Fix for focus tracking in isolated tree mode.
Comment 1 Andres Gonzalez 2020-12-08 18:20:18 PST
Created attachment 415697 [details]
Patch
Comment 2 chris fleizach 2020-12-08 18:25:39 PST
Comment on attachment 415697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415697&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:482
> +            if (!backingObject)

Can this code here be moved into AccessibilityObject? It seems like a lot of core work in the platform wrapper
Comment 3 Andres Gonzalez 2020-12-09 09:12:11 PST
Created attachment 415767 [details]
Patch
Comment 4 Andres Gonzalez 2020-12-09 09:13:21 PST
(In reply to chris fleizach from comment #2)
> Comment on attachment 415697 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415697&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:482
> > +            if (!backingObject)
> 
> Can this code here be moved into AccessibilityObject? It seems like a lot of
> core work in the platform wrapper

Done. Thanks!
Comment 5 EWS 2020-12-09 16:35:54 PST
Committed r270609: <https://trac.webkit.org/changeset/270609>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415767 [details].
Comment 6 Radar WebKit Bug Importer 2020-12-09 16:36:15 PST
<rdar://problem/72158498>