Bug 219656

Summary: TextManipulationController sometimes fails to notify its delegate of new text (if an element has been removed)
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mifenton, sihui_liu, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202874    
Attachments:
Description Flags
Patch
wenson_hsieh: review+
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Description Geoffrey Garen 2020-12-08 14:26:05 PST 
TextManipulationController sometimes fails to notify its delegate of new text (if an element has been removed)
Comment 1 Geoffrey Garen 2020-12-08 14:38:04 PST 
Created attachment 415678 [details]
Patch
Comment 2 Wenson Hsieh 2020-12-08 14:41:05 PST 
Comment on attachment 415678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415678&action=review

r=mews

> Source/WebCore/editing/TextManipulationController.cpp:646
> +    if (!m_pendingItemsForCallback.size())

Nit - I think .isEmpty() might read a bit better here.
Comment 3 Geoffrey Garen 2020-12-08 15:15:14 PST 
Created attachment 415681 [details]
Patch for landing
Comment 4 EWS 2020-12-08 15:16:18 PST 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 5 Geoffrey Garen 2020-12-08 15:19:46 PST 
Created attachment 415682 [details]
Patch for landing
Comment 6 EWS 2020-12-08 16:04:00 PST 
Committed r270561: <https://trac.webkit.org/changeset/270561>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415682 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-08 16:07:00 PST 
<rdar://problem/72113973>