Bug 219654

Summary: [iOS][FCR] Add new look for color inputs
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
wenson_hsieh: review+
Patch for landing
none
Address post-review comments none

Aditya Keerthi
Reported 2020-12-08 13:38:20 PST
...
Attachments
Patch (19.42 KB, patch)
2020-12-08 13:41 PST, Aditya Keerthi 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch for landing (19.36 KB, patch)
2020-12-10 17:03 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Address post-review comments (1.57 KB, patch)
2020-12-11 11:31 PST, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2020-12-08 13:38:39 PST
<rdar://problem/72107493>
Aditya Keerthi
Comment 2 2020-12-08 13:41:16 PST
Created attachment 415671 [details] Patch
Aditya Keerthi
Comment 3 2020-12-10 17:03:26 PST
Created attachment 415947 [details] Patch for landing
EWS
Comment 4 2020-12-11 08:42:42 PST
Committed r270678: <https://trac.webkit.org/changeset/270678> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415947 [details].
Darin Adler
Comment 5 2020-12-11 09:28:58 PST
Comment on attachment 415947 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=415947&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:2333 > + constexpr DisplayP3<float> colorStops[] = { Either this should specifically use numColorStops, or we should write something like this instead: const int numColorStops = std::size(colorStops);
Aditya Keerthi
Comment 6 2020-12-11 11:31:10 PST
Reopening to attach new patch.
Aditya Keerthi
Comment 7 2020-12-11 11:31:12 PST
Created attachment 416019 [details] Address post-review comments
EWS
Comment 8 2020-12-11 12:53:33 PST
Committed r270704: <https://trac.webkit.org/changeset/270704> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416019 [details].
Note You need to log in before you can comment on or make changes to this bug.