Bug 219654

Summary: [iOS][FCR] Add new look for color inputs
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: iPhone / iPad   
OS: Unspecified   
Description Flags
wenson_hsieh: review+
Patch for landing
Address post-review comments none

Description Aditya Keerthi 2020-12-08 13:38:20 PST
Comment 1 Aditya Keerthi 2020-12-08 13:38:39 PST
Comment 2 Aditya Keerthi 2020-12-08 13:41:16 PST
Created attachment 415671 [details]
Comment 3 Aditya Keerthi 2020-12-10 17:03:26 PST
Created attachment 415947 [details]
Patch for landing
Comment 4 EWS 2020-12-11 08:42:42 PST
Committed r270678: <https://trac.webkit.org/changeset/270678>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415947 [details].
Comment 5 Darin Adler 2020-12-11 09:28:58 PST
Comment on attachment 415947 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=415947&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:2333
> +    constexpr DisplayP3<float> colorStops[] = {

Either this should specifically use numColorStops, or we should write something like this instead:

    const int numColorStops = std::size(colorStops);
Comment 6 Aditya Keerthi 2020-12-11 11:31:10 PST
Reopening to attach new patch.
Comment 7 Aditya Keerthi 2020-12-11 11:31:12 PST
Created attachment 416019 [details]
Address post-review comments
Comment 8 EWS 2020-12-11 12:53:33 PST
Committed r270704: <https://trac.webkit.org/changeset/270704>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416019 [details].