Summary: | [iOS][FCR] Add new look for color inputs | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||||||
Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, changseok, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Aditya Keerthi
2020-12-08 13:38:20 PST
Created attachment 415671 [details]
Patch
Created attachment 415947 [details]
Patch for landing
Committed r270678: <https://trac.webkit.org/changeset/270678> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415947 [details]. Comment on attachment 415947 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=415947&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:2333 > + constexpr DisplayP3<float> colorStops[] = { Either this should specifically use numColorStops, or we should write something like this instead: const int numColorStops = std::size(colorStops); Reopening to attach new patch. Created attachment 416019 [details]
Address post-review comments
Committed r270704: <https://trac.webkit.org/changeset/270704> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416019 [details]. |