Bug 219645

Summary: prepare-ChangeLog won't parse rdar://nnnnnnnn URLs in fetchRadarURLFromBugXMLData()
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, jbedard, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=222863
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2020-12-08 08:09:58 PST
prepare-ChangeLog won't parse rdar://nnnnnnnn URLs in fetchRadarURLFromBugXMLData().

sub fetchRadarURLFromBugXMLData($$)
{
    my ($bugNumber, $bugXMLData) = @_;

    return "" if $bugXMLData !~ m|<thetext>\s*(&lt;rdar://problem/\d+&gt;)|;

    my $bugRadarURL = decodeEntities($1);
    print STDERR "  Radar URL from bug $bugNumber:\n    \"$bugRadarURL\".\n";
    return $bugRadarURL;
}

Tests in:  Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl
Comment 1 Radar WebKit Bug Importer 2020-12-10 08:51:46 PST
<rdar://problem/72182806>
Comment 2 David Kilzer (:ddkilzer) 2020-12-10 09:18:57 PST
Created attachment 415882 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2020-12-10 10:03:00 PST
Comment on attachment 415882 [details]
Patch v1

Adding cq+ since the webkitperl tests passed, and this script isn't used in a build.
Comment 4 EWS 2020-12-10 10:06:04 PST
Committed r270631: <https://trac.webkit.org/changeset/270631>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415882 [details].