Summary: | [WASM-References] Add support for type annotated select | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry <dbezhetskov> | ||||||||||
Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Dmitry
2020-12-07 03:00:30 PST
Created attachment 415547 [details]
Patch
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json". Created attachment 416114 [details]
Patch
Comment on attachment 416114 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416114&action=review > Source/JavaScriptCore/ChangeLog:10 > + https://webassembly.github.io/reference-types/core/binary/instructions.html#parametric-instructions. Can you describe about 1. what this opcode is. Including motivation why it is introduced etc. 2. how it is executed (semantics) in ChangeLog? Created attachment 416143 [details]
Patch
Comment on attachment 416143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=416143&action=review > Source/JavaScriptCore/wasm/WasmFunctionParser.h:652 > + m_expressionStack.constructAndAppend(zero.type(), result); Using immediates.targetType is better for future extension? > Source/JavaScriptCore/wasm/wasm.json:48 > + "annotated_select": { "category": "control", "value": 28, "return": ["prev"], "parameter": ["any", "prev", "bool"], "immediate": [{"name": "value_type", "type": "value_type"}], "description": "the same as just select but with a value type immediate" }, https://webassembly.github.io/reference-types/core/binary/instructions.html#parametric-instructions is showing `πΆπ‘π·π² π‘β:πππ(πππππ’ππ)`, but it looks like this definition is not that one. Can you fix it? br_table's definition would be useful to fix it. > JSTests/wasm/wasm.json:48 > + "annotated_select": { "category": "control", "value": 28, "return": ["prev"], "parameter": ["any", "prev", "bool"], "immediate": [{"name": "value_type", "type": "value_type"}], "description": "the same as just select but with a value type immediate" }, Ditto. Created attachment 416225 [details]
Patch
Comment on attachment 416225 [details]
Patch
r=me
Committed r270827: <https://trac.webkit.org/changeset/270827> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416225 [details]. |