Bug 219580

Summary: [WebKit] Fix build when GPU_PROCESS is disabled
Product: WebKit Reporter: Samuel Thibault <samuel.thibault>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: fujii.hironori, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
none
Patch none

Samuel Thibault
Reported 2020-12-06 08:54:24 PST
Created attachment 415517 [details] proposed fix When GPU_PROCESS is disabled, RemoteMediaEngineConfigurationFactoryProxy is disabled in the .h file but not in the .cpp file and its reference.
Attachments
proposed fix (1.72 KB, patch)
2020-12-06 08:54 PST, Samuel Thibault 		no flags
DetailsFormatted DiffDiff
Patch (2.20 KB, patch)
2020-12-06 13:03 PST, Samuel Thibault 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-12-06 11:58:10 PST
Thank you very much for taking time to report bug and submit your proposed patch. Could you follow the contribution workflow? https://webkit.org/contributing-code/
Samuel Thibault
Comment 2 2020-12-06 12:03:04 PST
Well, that is what I did?
Fujii Hironori
Comment 3 2020-12-06 12:08:42 PST
Please use prepare-ChangeLog and 'webkit-patch upload' scripts.
Samuel Thibault
Comment 4 2020-12-06 13:03:44 PST
Created attachment 415528 [details] Patch
youenn fablet
Comment 5 2020-12-07 05:52:33 PST
Thanks Samuel for the patch. A similar fix was done in https://bugs.webkit.org/show_bug.cgi?id=219578. Closing this one as duplicate. *** This bug has been marked as a duplicate of bug 219578 ***
Note You need to log in before you can comment on or make changes to this bug.