Bug 219580

Summary: [WebKit] Fix build when GPU_PROCESS is disabled
Product: WebKit Reporter: Samuel Thibault <samuel.thibault>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: Hironori.Fujii, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix
none
Patch none

Description Samuel Thibault 2020-12-06 08:54:24 PST
Created attachment 415517 [details]
proposed fix

When GPU_PROCESS is disabled, RemoteMediaEngineConfigurationFactoryProxy is disabled in the .h file but not in the .cpp file and its reference.
Comment 1 Fujii Hironori 2020-12-06 11:58:10 PST
Thank you very much for taking time to report bug and submit your proposed patch. Could you follow the contribution workflow?
https://webkit.org/contributing-code/
Comment 2 Samuel Thibault 2020-12-06 12:03:04 PST
Well, that is what I did?
Comment 3 Fujii Hironori 2020-12-06 12:08:42 PST
Please use prepare-ChangeLog and 'webkit-patch upload' scripts.
Comment 4 Samuel Thibault 2020-12-06 13:03:44 PST
Created attachment 415528 [details]
Patch
Comment 5 youenn fablet 2020-12-07 05:52:33 PST
Thanks Samuel for the patch.
A similar fix was done in https://bugs.webkit.org/show_bug.cgi?id=219578.
Closing this one as duplicate.

*** This bug has been marked as a duplicate of bug 219578 ***