| Summary: | [JSC] get / set for object literal and class should not be escaped | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ashvayka, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-12-06 03:53:27 PST
Created attachment 415513 [details]
Patch
Comment on attachment 415513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415513&action=review Marvelous, r=me! > Source/JavaScriptCore/ChangeLog:8 > + "get" and "set" for getter and setter should not be escaped one. Perhaps it's worth to explain why not, in contrast to previous patch? Like: Terminal symbols of the lexical grammars are shown in fixed width font [1], and are to appear in a script exactly as written. [1]: https://tc39.es/ecma262/#sec-method-definitions Comment on attachment 415513 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415513&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + "get" and "set" for getter and setter should not be escaped one. > > Perhaps it's worth to explain why not, in contrast to previous patch? Like: > > Terminal symbols of the lexical grammars are shown in fixed width font [1], and are to appear in a script exactly as written. > > [1]: https://tc39.es/ecma262/#sec-method-definitions That's very nice! I've added :D Committed r270487: <https://trac.webkit.org/changeset/270487> |