Bug 219551 – Remove ENABLE_GRAPHICS_CONTEXT_GL by replacing it with ENABLE(WEBGL)

• Component: WebGL
• Status: RESOLVED FIXED

[Fujii Hironori]

Remove ENABLE_GRAPHICS_CONTEXT_GL by replacing it with ENABLE(WEBGL)

GraphicsContextGL is a module only for WebGL.
ENABLE_WEBGL should be removed if all ports enable it.

[Fujii Hironori]

Created attachment 415451 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Kenneth Russell]

Comment on attachment 415451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415451&action=review

Looks like a nice cleanup. As long as this builds everywhere, r+.

> Source/WebCore/platform/graphics/GLContext.cpp:21
> +#if USE(OPENGL) || USE(OPENGL_ES)

Wasn't immediately obvious to me that these two #if statements are functionally equivalent.

> Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:438
> +#endif // ENABLE(WEBGL) &&  || !USE(ANGLE)

Typo - please fix.

[Fujii Hironori]

Comment on attachment 415451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415451&action=review

Thank you very much for taking time to review my patch.

>> Source/WebCore/platform/graphics/GLContext.cpp:21
>> +#if USE(OPENGL) || USE(OPENGL_ES)
> 
> Wasn't immediately obvious to me that these two #if statements are functionally equivalent.

Yup, non-cocoa ports need to enable either of the macros to use OpenGL.

>> Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:438
>> +#endif // ENABLE(WEBGL) &&  || !USE(ANGLE)
> 
> Typo - please fix.

Will fix.

[Fujii Hironori]

Created attachment 415496 [details]
Patch for landing

[Fujii Hironori]

Committed r270477: <https://trac.webkit.org/changeset/270477>

[Radar WebKit Bug Importer]

<rdar://problem/72012254>

[monson]

Comment on attachment 415496 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=415496&action=review

> Source/cmake/OptionsGTK.cmake:-113
> -WEBKIT_OPTION_DEPEND(ENABLE_3D_TRANSFORMS ENABLE_GRAPHICS_CONTEXT_GL)
> -WEBKIT_OPTION_DEPEND(ENABLE_ASYNC_SCROLLING ENABLE_GRAPHICS_CONTEXT_GL)
> -WEBKIT_OPTION_DEPEND(ENABLE_GLES2 ENABLE_GRAPHICS_CONTEXT_GL)
> -WEBKIT_OPTION_DEPEND(ENABLE_WEBGL ENABLE_GRAPHICS_CONTEXT_GL)
>  WEBKIT_OPTION_DEPEND(USE_ANGLE_WEBGL ENABLE_WEBGL)
> -WEBKIT_OPTION_DEPEND(USE_WPE_RENDERER ENABLE_GRAPHICS_CONTEXT_GL)

I'm OK with killing ENABLE_GRAPHICS_CONTEXT_GL, but here (and somethere else) are some options depend on it. Would you consider a situation where we have neither OPENGL nor GLES2, and bring back some dependencies? I have hit the wrong assertion of USE_GSTREAMER_GL, ENABLE_3D_TRANSFORMS and ENABLE_ASYNC_SCROLLING already.

[Fujii Hironori]

Could you open a new bug or reopen bug 219916?