Bug 219540

Summary: [macOS] Create sandbox extension for audio service when Media in GPU process is not enabled
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Per Arne Vollan 2020-12-04 07:02:53 PST 
Create sandbox extension for com.apple.audio.SandboxHelper when Media in GPU process is not enabled.
Comment 1 Radar WebKit Bug Importer 2020-12-04 07:03:49 PST 
<rdar://problem/71978050>
Comment 2 Per Arne Vollan 2020-12-04 07:06:20 PST 
Created attachment 415411 [details]
Patch
Comment 3 Brent Fulgham 2020-12-08 10:37:54 PST 
Comment on attachment 415411 [details]
Patch

r=me
Comment 4 Brent Fulgham 2020-12-08 10:38:33 PST 
Comment on attachment 415411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415411&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1301
> +            "com.apple.accessibility.mediaaccessibilityd" "com.apple.audio.SandboxHelper" "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.videodecoder" "com.apple.coremedia.videoencoder"

Do we need to remove 'com.apple.audio.SandboxHelper' from another part of the sandbox, or make it a 'with-report' so we can be sure it's going through the new flow?
Comment 5 Per Arne Vollan 2020-12-08 11:09:05 PST 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 415411 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415411&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1301
> > +            "com.apple.accessibility.mediaaccessibilityd" "com.apple.audio.SandboxHelper" "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.videodecoder" "com.apple.coremedia.videoencoder"
> 
> Do we need to remove 'com.apple.audio.SandboxHelper' from another part of
> the sandbox, or make it a 'with-report' so we can be sure it's going through
> the new flow?

I was thinking we could gather telemetry with the other rule after we switch over to GPU, and then eventually remove it. Does that sound ok? Or would you prefer to remove it now?

Thanks for reviewing!
Comment 6 EWS 2020-12-08 11:21:16 PST 
Committed r270545: <https://trac.webkit.org/changeset/270545>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415411 [details].