Bug 219515

Summary: [LFC][Integration] REGRESSION: Event handler region is wrong
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Testcase
none
Screenshot
none
Patch
none
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2020-12-03 15:35:49 PST
Created attachment 415360 [details] Testcase Attached testcase has some event region leaking out of the element for the inline text.
Attachments
Testcase (702 bytes, text/html)
2020-12-03 15:35 PST, Simon Fraser (smfr) 		no flags
Details
Screenshot (544.77 KB, image/png)
2020-12-03 15:36 PST, Simon Fraser (smfr) 		no flags
Details
Patch (4.49 KB, patch)
2020-12-14 20:18 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.30 KB, patch)
2020-12-15 08:12 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.24 KB, patch)
2020-12-15 09:16 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-12-03 15:36:01 PST
Created attachment 415361 [details] Screenshot
Simon Fraser (smfr)
Comment 2 2020-12-03 15:38:15 PST
In LineLayout::paint() the event region is built using visualOverflowRect but it looks like that needs to be offset with paintOffset.
Radar WebKit Bug Importer
Comment 3 2020-12-03 15:39:59 PST
<rdar://problem/71955706>
alan
Comment 4 2020-12-14 20:18:51 PST
Created attachment 416222 [details] Patch
alan
Comment 5 2020-12-15 08:12:37 PST
Created attachment 416248 [details] Patch
alan
Comment 6 2020-12-15 09:16:26 PST
Created attachment 416254 [details] Patch
EWS
Comment 7 2020-12-15 09:47:52 PST
Committed r270848: <https://trac.webkit.org/changeset/270848> All reviewed patches have been landed. Closing bug and clearing flags on attachment 416254 [details].
Note You need to log in before you can comment on or make changes to this bug.