Summary: | [Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, peng.liu6, philipj, sergio, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Jer Noble
2020-12-03 12:24:42 PST
Created attachment 415324 [details]
Patch
Comment on attachment 415324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415324&action=review > Source/WebCore/PAL/ChangeLog:9 > + sharedSystemAudioContextânot the sharedAudioPresentationOutputContextâto do so. This context Nit. sharedSystemAudioContextânot and sharedAudioPresentationOutputContextâto. > Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:53 > + AVOutputContext* context = [getAVOutputContextClass() sharedSystemAudioContext]; Can this one use auto as well? > Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:139 > + if (devices.isEmpty() || !WTF::allOf(devices, [] (auto& device) { Nit. The space between square brackets and parentheses of the lambda function can be removed. Comment on attachment 415324 [details]
Patch
r=me with Peng's nit's addressed
(In reply to Peng Liu from comment #3) > Comment on attachment 415324 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415324&action=review > > > Source/WebCore/PAL/ChangeLog:9 > > + sharedSystemAudioContextânot the sharedAudioPresentationOutputContextâto do so. This context > > Nit. sharedSystemAudioContextânot and > sharedAudioPresentationOutputContextâto. Ooh, fun UTF character there. > > Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:53 > > + AVOutputContext* context = [getAVOutputContextClass() sharedSystemAudioContext]; > > Can this one use auto as well? No; the compiler complains that the deducted type is "id". > > Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:139 > > + if (devices.isEmpty() || !WTF::allOf(devices, [] (auto& device) { > > Nit. The space between square brackets and parentheses of the lambda > function can be removed. Ok. Created attachment 415447 [details]
Patch for landing
Committed r270463: <https://trac.webkit.org/changeset/270463> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415447 [details]. |