Bug 219497

Summary: Refactor macros for low power mode code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, ews-watchlist, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Chris Dumez
Reported 2020-12-03 10:42:18 PST
Refactor macros for low power mode code.
Attachments
Patch (16.55 KB, patch)
2020-12-03 10:44 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.18 KB, patch)
2020-12-03 10:55 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.70 KB, patch)
2020-12-03 11:33 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (17.97 KB, patch)
2020-12-03 11:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-12-03 10:44:56 PST
Created attachment 415311 [details] Patch
Chris Dumez
Comment 2 2020-12-03 10:55:21 PST
Created attachment 415313 [details] Patch
Chris Dumez
Comment 3 2020-12-03 11:33:08 PST
Created attachment 415315 [details] Patch
Chris Dumez
Comment 4 2020-12-03 11:43:45 PST
Created attachment 415316 [details] Patch
Geoffrey Garen
Comment 5 2020-12-03 12:49:04 PST
Comment on attachment 415316 [details] Patch r=me
EWS
Comment 6 2020-12-03 13:15:19 PST
Committed r270406: <https://trac.webkit.org/changeset/270406> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415316 [details].
Radar WebKit Bug Importer
Comment 7 2020-12-03 13:16:21 PST
<rdar://problem/71949711>
Sam Weinig
Comment 8 2020-12-19 11:34:20 PST
Comment on attachment 415316 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415316&action=review > Source/WebCore/platform/cocoa/LowPowerModeNotifier.mm:104 > +#endif // PLATFORM(APPLE_LOW_POWER_MODE_SUPPORT) This should say HAVE(APPLE_LOW_POWER_MODE_SUPPORT).
Note You need to log in before you can comment on or make changes to this bug.